fix: add UTF-8 encoding environment variables to VSCode terminal #8939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added LANG and LC_ALL environment variables set to en_US.UTF-8 - This ensures proper handling of UTF-8 characters in terminal commands - Added comprehensive tests for UTF-8 environment setup - Updated existing tests to expect the new environment variables Fixes #8938
dosubot
bot
added
size:L
Code Review SummaryNo issues found. The changes correctly implement UTF-8 encoding environment variables for the VSCode terminal, matching the approach already used in ExecaTerminal. The implementation is well-tested and should resolve the encoding errors described in issue #8938. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
|
Unable to reproduce the issue this PR is trying to fix. After testing UTF-8 commands on macOS with proper locale settings, all commands execute correctly without any encoding issues. Since the original issue #8938 appears to be environment-specific (VSCodium + Linux + apparmor) and cannot be reproduced on standard configurations, this fix is not needed. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #8938 where UTF-8 characters in terminal commands were causing encoding errors.
Problem
When running Python commands with special characters like arrows (→), lambda (λ), Chinese characters (中文), or emoji (😀) through Roo Code's terminal, users were encountering encoding errors like:
Solution
Added UTF-8 encoding environment variables (
LANGandLC_ALLset toen_US.UTF-8) to the VSCode terminal environment configuration. This ensures proper handling of UTF-8 characters in terminal commands, matching the configuration already present in ExecaTerminal.Changes
LANG: "en_US.UTF-8"andLC_ALL: "en_US.UTF-8"to Terminal.getEnv() methodTesting
Fixes #8938
Feedback and guidance are welcome!
Important
Adds UTF-8 encoding environment variables to VSCode terminal to handle special characters.
LANG: "en_US.UTF-8"andLC_ALL: "en_US.UTF-8"toTerminal.getEnv()inTerminal.tsto handle UTF-8 characters.Terminal.spec.tsto verify UTF-8 environment variables are set.TerminalRegistry.spec.tsto expect new environment variables.This description was created by
for 3c0b574. You can customize this summary. It will automatically update as commits are pushed.